Repository navigation
fix(redfishwrapper): skip absent prerequisite attributes in SetNetworkBootEnabled - #473
Merged
mergify[bot] merged 1 commit intoOct 1, 2026
Conversation
…kBootEnabled The Supermicro/AMI table always PATCHes NetworkStack and BootModeSelect along with the protocol switches. The fingerprint only confirms IPv4HTTPSupport exists, so a BIOS without BootModeSelect (Supermicro AS-1015CS-TNR-EU, BIOS 3.8) rejects the whole request with "The value 'null' for the property BootModeSelect is not a type that the property can accept" (HTTP 400). The same PATCH without BootModeSelect is accepted. Mark NetworkStack and BootModeSelect as optionalWhenAbsent and drop them from the PATCH when the BIOS configuration doesn't list them. The protocol switches stay required. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
joelrebel
approved these changes
Oct 1, 2026
Contributor
Merge Queue Status
This pull request spent 13 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
SetNetworkBootEnabledalways PATCHesNetworkStackandBootModeSelectalong with the protocol switches. The Supermicro AS-1015CS-TNR-EU BIOS has noBootModeSelect, so the BMC rejects the whole request:NetworkStackandBootModeSelectare now dropped from the PATCH when the BIOS doesn't list them. The protocol switches are still required.On that board, the PATCH is rejected (400) with
BootModeSelectand accepted (202) without it.Checklist
The HW vendor this change applies to (if applicable)
Supermicro
The HW model number, product name this change applies to (if applicable)
AS-1015CS-TNR-EU
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
BMC 01.09.02, BIOS 3.8
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
None
Description for changelog/release notes